Remove metric options; rename "counter" aggregator to "sum" #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
MrAlias
approved these changes
Mar 11, 2020
|
I plan to merge this. There have been a number of high-velocity changes lately, but they are mostly code deletion. The reason for velocity is that it lets me work on the next steps for the beta without tremendous merge conflicts. In this case, the PR to finish #514 really should build on top of this PR. |
MrAlias
approved these changes
Mar 12, 2020
MikeGoldsmith
pushed a commit
to MikeGoldsmith/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
…emetry#541) * Remove options (mostly) * Rename counter aggregator to 'sum' * Fix prometheus test * Rewordings from feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #540.
Removes a lot of v0.2 specification leftovers.
"counter" to "sum" brings this SDK into line w/ the draft SDK spec
See also #536 standardization.