Remove unneeded metrictest types #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
…go into rm-dup-metrictest
Codecov Report
@@ Coverage Diff @@
## main #2864 +/- ##
=======================================
- Coverage 75.7% 75.7% -0.1%
=======================================
Files 180 179 -1
Lines 11818 11818
=======================================
- Hits 8953 8951 -2
- Misses 2632 2634 +2
Partials 233 233
|
MadVikingGod
approved these changes
Apr 26, 2022
dashpole
approved these changes
Apr 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExportRecordtype introduced in #2776 duplicates the existingBatchandMeasurmenttypes. Remove the old types in favor of the added type.