-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an Inmemory Exporter for test #2776
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2776 +/- ##
======================================
Coverage 75.7% 75.7%
======================================
Files 178 180 +2
Lines 11707 11818 +111
======================================
+ Hits 8864 8951 +87
- Misses 2618 2634 +16
- Partials 225 233 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and is definitely a useful starting point.
Having used prometheus a bunch for metrics, i've come to really like the GatherAndCompare (to a file) approach for testing. Its nice to have metrics represented in files if I need to do a large number of assertions about my metrics. It would be neat to be able to make assertions against a json OTLP file or something. Or, I guess, I can just use the prom exporter with GatherAndCompare to meet my use-case :)...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This change creates an in-memory exporter for use in tests.
Closes: #2722
This affects a number of instruments in the contrib repo. An example of what this can re-enable is: MadVikingGod/opentelemetry-go-contrib@1e9dd43