-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated the bridge/opencensus/utils package #2166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo,
pellared and
XSAM
as code owners
August 6, 2021 16:52
Codecov Report
@@ Coverage Diff @@
## main #2166 +/- ##
=======================================
- Coverage 72.4% 72.3% -0.2%
=======================================
Files 176 176
Lines 12091 12095 +4
=======================================
- Hits 8765 8755 -10
- Misses 3091 3102 +11
- Partials 235 238 +3
|
MrAlias
commented
Aug 6, 2021
MrAlias
commented
Aug 6, 2021
jmacd
approved these changes
Aug 6, 2021
dashpole
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opencensus
package is defined to provide a migration bridge from OpenCensus to OpenTelemetry. It would follow that this package would contain all the translation functions for this purpose. Having a separateutils
package only adds confusion about where things are. Give the package name is non-descriptive and there is no clear documentation about what purpose it has removing it and unify all OpenCensus bridging functionality in theopencensus
package make sense.Part of #2144