Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated the bridge/opencensus/utils package #2166

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 6, 2021

The opencensus package is defined to provide a migration bridge from OpenCensus to OpenTelemetry. It would follow that this package would contain all the translation functions for this purpose. Having a separate utils package only adds confusion about where things are. Give the package name is non-descriptive and there is no clear documentation about what purpose it has removing it and unify all OpenCensus bridging functionality in the opencensus package make sense.

Part of #2144

@MrAlias MrAlias added the pkg:bridges Related to a bridge package label Aug 6, 2021
@MrAlias MrAlias mentioned this pull request Aug 6, 2021
5 tasks
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #2166 (dbf1599) into main (b1d1d52) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2166     +/-   ##
=======================================
- Coverage   72.4%   72.3%   -0.2%     
=======================================
  Files        176     176             
  Lines      12091   12095      +4     
=======================================
- Hits        8765    8755     -10     
- Misses      3091    3102     +11     
- Partials     235     238      +3     
Impacted Files Coverage Δ
bridge/opencensus/bridge.go 0.0% <0.0%> (ø)
bridge/opencensus/utils/utils.go 0.0% <ø> (ø)
sdk/metric/refcount_mapped.go 80.0% <0.0%> (-20.0%) ⬇️
...s/otlp/otlptrace/internal/connection/connection.go 14.8% <0.0%> (-1.6%) ⬇️
sdk/metric/sdk.go 79.5% <0.0%> (-1.5%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
bridge/opencensus/utils/utils.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit a3d4ff5 into open-telemetry:main Aug 9, 2021
@MrAlias MrAlias deleted the dep-oc-utils branch August 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:bridges Related to a bridge package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants