-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the OpenCensus Bridge #2144
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2144 +/- ##
=======================================
+ Coverage 72.2% 72.3% +0.1%
=======================================
Files 176 175 -1
Lines 12088 12088
=======================================
+ Hits 8731 8745 +14
+ Misses 3115 3103 -12
+ Partials 242 240 -2
|
I'm going to split this up. |
This was referenced Aug 6, 2021
Slit into the constituent parts mentioned in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpanRecorder
to test the bridge in the newtest
package instead of theoteltest
package. (Move OpenCensus bridge integration tests to their own module #2165)internal
package so thetest
package has access to conversions and types for testing. (Add OpenCensus bridge internal package #2146)utils
package. Instead, move the conversion functions it contained to the main package. (Deprecated the bridge/opencensus/utils package #2166)Part of #2121