Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove propagation testing types from oteltest #2116

Merged
merged 5 commits into from
Jul 22, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 21, 2021

The only place I can find these types being referenced here or in the contrib repo is in the internal/global package. Move these types internal and deprecate the exported versions. This removes the last oteltest dependency the otel package has after #2111 and is a part of #2077.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2116 (bd6a432) into main (25d739b) will increase coverage by 0.1%.
The diff coverage is 75.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2116     +/-   ##
=======================================
+ Coverage   73.1%   73.2%   +0.1%     
=======================================
  Files        165     167      +2     
  Lines       8155    8237     +82     
=======================================
+ Hits        5965    6035     +70     
- Misses      1961    1971     +10     
- Partials     229     231      +2     
Impacted Files Coverage Δ
oteltest/text_map_propagator.go 76.2% <ø> (ø)
internal/internaltest/text_map_carrier.go 73.0% <73.0%> (ø)
internal/internaltest/text_map_propagator.go 80.0% <80.0%> (ø)
sdk/metric/sdk.go 83.7% <0.0%> (+3.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+22.2%) ⬆️

@MrAlias MrAlias merged commit 7f10ef7 into open-telemetry:main Jul 22, 2021
@MrAlias MrAlias deleted the propagationtest branch July 22, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants