Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal/global/trace testing #2111

Merged
merged 5 commits into from
Jul 22, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 21, 2021

Use existing testing types instead of the oteltest package.

Part of #2077

Use existing testing types instead of the oteltest package.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2111 (14b6fc7) into main (7f10ef7) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2111     +/-   ##
=======================================
- Coverage   73.1%   72.9%   -0.2%     
=======================================
  Files        167     167             
  Lines       8237    8237             
=======================================
- Hits        6027    6011     -16     
- Misses      1977    1992     +15     
- Partials     233     234      +1     
Impacted Files Coverage Δ
oteltest/config.go 72.9% <0.0%> (-21.7%) ⬇️
trace/config.go 61.2% <0.0%> (-14.3%) ⬇️
oteltest/span.go 97.1% <0.0%> (-2.9%) ⬇️
trace/noop.go 56.2% <0.0%> (+6.2%) ⬆️

@MrAlias MrAlias merged commit db81d4a into open-telemetry:main Jul 22, 2021
@MrAlias MrAlias deleted the gtrace-test-deps branch July 22, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants