Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update function docs in sdk.go #1826

Merged
merged 8 commits into from
Apr 20, 2021
Merged

Update function docs in sdk.go #1826

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b4d525
Made copy of attribute.KeyValue
IrisTuntun Apr 14, 2021
63c06c3
Add comments and test
IrisTuntun Apr 15, 2021
3395d8a
move test to sdk/metric
IrisTuntun Apr 16, 2021
70e6a4c
Update CHANGELOG.md
IrisTuntun Apr 19, 2021
68adab8
Add label order assertions for final results
IrisTuntun Apr 19, 2021
20756a6
Update CHANGELOG PR number
IrisTuntun Apr 20, 2021
df10cfd
Revert code changes and update docs
IrisTuntun Apr 20, 2021
a8df69c
Merge branch 'main' into recordBatch
MrAlias Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/metric/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,12 @@ func (s *syncInstrument) acquireHandle(kvs []attribute.KeyValue, labelPtr *attri
}
}

// The order of the input array `kvs` may be sorted after the function is called.
func (s *syncInstrument) Bind(kvs []attribute.KeyValue) metric.BoundSyncImpl {
return s.acquireHandle(kvs, nil)
}

// The order of the input array `kvs` may be sorted after the function is called.
func (s *syncInstrument) RecordOne(ctx context.Context, num number.Number, kvs []attribute.KeyValue) {
h := s.acquireHandle(kvs, nil)
defer h.Unbind()
Expand Down Expand Up @@ -396,6 +398,7 @@ func (m *Accumulator) collectSyncInstruments() int {
}

// CollectAsync implements internal.AsyncCollector.
// The order of the input array `kvs` may be sorted after the function is called.
func (m *Accumulator) CollectAsync(kv []attribute.KeyValue, obs ...metric.Observation) {
labels := attribute.NewSetWithSortable(kv, &m.asyncSortSlice)

Expand Down Expand Up @@ -472,6 +475,7 @@ func (m *Accumulator) checkpointAsync(a *asyncInstrument) int {
}

// RecordBatch enters a batch of metric events.
// The order of the input array `kvs` may be sorted after the function is called.
func (m *Accumulator) RecordBatch(ctx context.Context, kvs []attribute.KeyValue, measurements ...metric.Measurement) {
// Labels will be computed the first time acquireHandle is
// called. Subsequent calls to acquireHandle will re-use the
Expand Down