Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function docs in sdk.go #1826

Merged
merged 8 commits into from
Apr 20, 2021
Merged

Conversation

IrisTuntun
Copy link
Contributor

@IrisTuntun IrisTuntun commented Apr 20, 2021

Update function docs in sdk.go to indicate the order of the input array kvs may be sorted after the function is called.
Should resolve #1787

sdk/metric/sdk.go Outdated Show resolved Hide resolved
@IrisTuntun IrisTuntun changed the title Made copy of attribute.KeyValue before sorting Update function docs in sdk.go Apr 20, 2021
@MrAlias MrAlias added Skip Changelog PRs that do not require a CHANGELOG.md entry area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information labels Apr 20, 2021
@MrAlias MrAlias merged commit 66389ad into open-telemetry:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordBatch mutates the provided slice of attributes
3 participants