Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jaeger exporter convenience functions #1822

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 19, 2021

Replace the flush function returned from the Jaeger exporter's convenience creation functions (InstallNewPipeline and NewExportPipeline) with the TracerProvider implementation they create. This enables the caller to shutdown and flushing of the using the related TracerProvider methods.

Additionally this updates the associated unit tests for these functions to test their functionality directly instead of testing functional options of the trace API's TracerProvider.

Resolves #1725
Resolves #1327
Part of #1799

@MrAlias MrAlias added release:1.0.0-rc.1 pkg:exporter:jaeger Related to the Jaeger exporter package labels Apr 19, 2021
@MrAlias MrAlias added this to the RC1 milestone Apr 19, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1822 (cc97540) into main (1b9f16d) will decrease coverage by 0.2%.
The diff coverage is 60.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1822     +/-   ##
=======================================
- Coverage   78.3%   78.1%   -0.3%     
=======================================
  Files        135     135             
  Lines       7245    7245             
=======================================
- Hits        5680    5665     -15     
- Misses      1315    1331     +16     
+ Partials     250     249      -1     
Impacted Files Coverage Δ
exporters/trace/jaeger/jaeger.go 88.7% <60.0%> (-2.3%) ⬇️
exporters/trace/jaeger/uploader.go 36.9% <0.0%> (-12.4%) ⬇️
sdk/trace/batch_span_processor.go 82.4% <0.0%> (-1.6%) ⬇️

@MrAlias MrAlias merged commit 081cc61 into open-telemetry:main Apr 20, 2021
@MrAlias MrAlias deleted the jaeger-tp-return branch April 20, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
None yet
3 participants