-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convenience functions NewExportPipeline
and InstallNewPipeline
can not be flushed.
#1725
Comments
One thing that I noticed while working this is that Jaeger's exporter has a built-in batcher. This will probably lead to odd behavior when using Jaeger + the batching span processor. |
I found this as well while working on #1380. I'm still thinking it through, but I think we need to rip the bundler out of the Jaeger exporter for just this reason. |
Tracking with #1799 |
Would it make sense to have these same convenience functions as part of We could have a similar one in the |
This sounds like something we could add after an RC. I'd be interested to get some user feedback on how to solve this before we implement a solution here. |
The only outstanding exporter is Jaeger. I was going to let the bundler work finish if it doesn't take care of it for me. |
We need #1806 to merge before we can update the Jaeger convenience functions. Otherwise, we are returning either a default SDK or a No-Op SDK. |
Currently, the exporters stdout, jaeger, and zipkin offer convenience functions for getting started quickly exporting data in these formats. When using these functions there isn't a direct or obvious way to flush or shutdown the TracerProviders that are created.
A workaround I've found is to cast the global TracerProvider to a
*sdktrace.TracerProvider
, eg.otel.GetTracerProvider().(*sdktrace.TracerProvider)
Possible solutions:
Shutdown()
. These should iterate over *Provider and call the associated shutdown. We would also need to define the signature of the shutdown that will be called.The text was updated successfully, but these errors were encountered: