-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the WithDisabled option from Jaeger exporter #1806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
release:1.0.0-rc.1
pkg:exporter:jaeger
Related to the Jaeger exporter package
labels
Apr 13, 2021
MrAlias
requested review from
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
April 13, 2021 17:54
Aneurysm9
approved these changes
Apr 13, 2021
MadVikingGod
approved these changes
Apr 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #1806 +/- ##
=======================================
- Coverage 78.4% 78.3% -0.1%
=======================================
Files 135 135
Lines 7249 7245 -4
=======================================
- Hits 5686 5680 -6
- Misses 1313 1315 +2
Partials 250 250
|
paivagustavo
approved these changes
Apr 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WithDisabled
option was added to support standard environment variables used by other Jaeger clients here. The goal was to add support for these environment variables to the extent that they make sense in the OpenTelemetry project.Support for this environment variable,
JAEGER_DISABLED
, was removed here. This seems appropriate as exporter activation or deactivation is handled by registering or unregistering it with the TracerProvider, or, at an earlier phase of initialization, by using the no-op TracerProvider itself. Given there are already mechanisms to disable the export of the Jaeger exporter in OpenTelemetry it would make sense to remove this duplicate mechanism.This removes the option that was added in parallel for the support of the environment variable.
Part of #1803