Update precedence of event name in Jaeger exporter #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTel specification states that the event needs to be recorded as a log with its name set to a tag having the "event" key. That key needs to be overridden when there is an attribute with the same key. This updates to implement this. Resolves open-telemetry#1767
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1768 +/- ##
=====================================
Coverage 78.6% 78.6%
=====================================
Files 133 133
Lines 7083 7087 +4
=====================================
+ Hits 5569 5573 +4
Misses 1268 1268
Partials 246 246
|
Aneurysm9
approved these changes
Apr 1, 2021
XSAM
approved these changes
Apr 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTel specification states that the event needs to be recorded as a log with its name set to a tag having the "event" key. That key needs to be overridden when there is an attribute with the same key. This updates to implement this.
Resolves #1767