Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update precedence of event name in Jaeger exporter #1767

Closed
MrAlias opened this issue Apr 1, 2021 · 0 comments · Fixed by #1768
Closed

Update precedence of event name in Jaeger exporter #1767

MrAlias opened this issue Apr 1, 2021 · 0 comments · Fixed by #1768
Assignees
@MrAlias

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 1, 2021

From the specification:

If OpenTelemetry Event contains an attributes with the key event, it should take precedence over Event's name field.

Currently, this is not done:

opentelemetry-go/exporters/trace/jaeger/jaeger.go

Lines 289 to 296 in 97501a3

fields := make([]*gen.Tag, 0, len(a.Attributes))
for _, kv := range a.Attributes {
tag := keyValueToTag(kv)
if tag != nil {
fields = append(fields, tag)
}
}
fields = append(fields, getStringTag("name", a.Name))

@MrAlias MrAlias mentioned this issue Apr 1, 2021
Closed
5 tasks
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Apr 1, 2021
@MrAlias
Update precedence of event name in Jaeger exporter
cd1775a 
The OTel specification states that the event needs to be recorded as a
log with its name set to a tag having the "event" key. That key needs to
be overridden when there is an attribute with the same key. This updates
to implement this.

Resolves open-telemetry#1767
@MrAlias MrAlias mentioned this issue Apr 1, 2021
Merged
@MrAlias MrAlias self-assigned this Apr 1, 2021
MrAlias added a commit that referenced this issue Apr 2, 2021
@MrAlias
Update precedence of event name in Jaeger exporter (#1768)
35cfbc7 
* Update precedence of event name in Jaeger exporter

The OTel specification states that the event needs to be recorded as a
log with its name set to a tag having the "event" key. That key needs to
be overridden when there is an attribute with the same key. This updates
to implement this.

Resolves #1767

* Add changes to changelog

* Update PR number in changelog

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update precedence of event name in Jaeger exporter MrAlias/opentelemetry-go
1 participant
@MrAlias