Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin Exporter: Adjust span transformation to comply with the spec #1688

Merged
merged 10 commits into from
Apr 7, 2021
Merged

Zipkin Exporter: Adjust span transformation to comply with the spec #1688

merged 10 commits into from
Apr 7, 2021

Commits on Mar 11, 2021

  1. Adjust instrumentation lib name / version key

    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c69e2da View commit details
    Browse the repository at this point in the history

  2. Adjust array attribute serialization

    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    8220103 View commit details
    Browse the repository at this point in the history

  3. Adjust span status mapping 

    - remove `otel.status_description`; use `error` instead for description
- do not report status code if unset
- do not report description if OK or unset
- omit tags if no tag has been mapped
- adjust tests
    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d6281a6 View commit details
    Browse the repository at this point in the history

  4. Set remote endpoint according to the spec 

    - See
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#remote-endpoint
    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c59ee42 View commit details
    Browse the repository at this point in the history

  5. Fix remaining tests

    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    f49fed7 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG

    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6554d10 View commit details
    Browse the repository at this point in the history

  7. Add some more tests

    @matej-g
    matej-g committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d4181bf View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Address PR feedback 

    - Simplify deletion of redundant error code
- Simplify endpoint rank determination
    @matej-g
    matej-g committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    a3ed80c View commit details
    Browse the repository at this point in the history

  2. More tests for remote endpoint

    @matej-g
    matej-g committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3b78eab View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into zipkin-exporter-span-… 

    …adjustments-spec
    @matej-g
    matej-g committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    ccdf86c View commit details
    Browse the repository at this point in the history