Zipkin Exporter: Adjust span transformation to comply with the spec #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1688 +/- ##
=======================================
+ Coverage 78.7% 78.8% +0.1%
=======================================
Files 134 134
Lines 7116 7157 +41
=======================================
+ Hits 5602 5643 +41
Misses 1268 1268
Partials 246 246
|
matej-g
force-pushed
the
zipkin-exporter-span-adjustments-spec
branch
from
a11ea39
to
6adf24e
Compare
- remove `otel.status_description`; use `error` instead for description - do not report status code if unset - do not report description if OK or unset - omit tags if no tag has been mapped - adjust tests
matej-g
force-pushed
the
zipkin-exporter-span-adjustments-spec
branch
from
6adf24e
to
d4181bf
Compare
matej-g
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
Great work! |
evantorrie
reviewed
Mar 13, 2021
jcchavezs
reviewed
Mar 14, 2021
jcchavezs
reviewed
Mar 14, 2021
jcchavezs
reviewed
Mar 14, 2021
|
Overall it looks great, my only strong concern is the usage of |
5 tasks
MrAlias
reviewed
Apr 6, 2021
- Simplify deletion of redundant error code - Simplify endpoint rank determination
MrAlias
approved these changes
Apr 7, 2021
Aneurysm9
approved these changes
Apr 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification for Zipkin exporter specifies a number of requirements on how the span data should be mapped between OpenTelemetry and Zipkin.
This PR intends to correct some discrepancies which have been found previously, in particular:
otel.library.*instead ofotel.instrumentation_library.*(relevant section)otel.status_descriptionand useerrorinstead; Do not report Unset status and do not include status message for Ok / Unset span status (relevant section).remoteEndpointaccording to the specification (relevant section)Includes test changes as well.
Related issue
An issue for setting the service name is still pending in #1549
Resolves (partially) #1376.