-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of oteltest in otelgocql #998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
area: instrumentation
Related to an instrumentation package
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
labels
Aug 13, 2021
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo and
pellared
as code owners
August 13, 2021 22:02
Codecov Report
@@ Coverage Diff @@
## main #998 +/- ##
=======================================
+ Coverage 74.9% 75.1% +0.1%
=======================================
Files 71 76 +5
Lines 4462 4766 +304
=======================================
+ Hits 3346 3580 +234
- Misses 979 1036 +57
- Partials 137 150 +13
|
dashpole
approved these changes
Aug 16, 2021
MadVikingGod
approved these changes
Aug 18, 2021
MrAlias
force-pushed
the
otelgocql-oteltest
branch
from
August 18, 2021 17:21
f9f3f6b
to
6bd2555
Compare
MrAlias
force-pushed
the
otelgocql-oteltest
branch
from
August 18, 2021 17:27
6bd2555
to
ae40b6a
Compare
MrAlias
force-pushed
the
otelgocql-oteltest
branch
from
August 18, 2021 17:52
fc8589f
to
e0168d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: instrumentation
Related to an instrumentation package
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of the
oteltest
package with thesdk/trace/tracetest
package for theotelecho
instrumentation. Do this in its owntest
module to not impose a dependency on the default SDK to the instrumentation user.This uses a pre-release version of the
sdk/trace/tracetest
to prepare for the next release of otel-go.Resolves #974
Part of open-telemetry/opentelemetry-go#2121