Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of oteltest in otelgocql #998

Merged
merged 8 commits into from
Aug 18, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 13, 2021

Replace the use of the oteltest package with the sdk/trace/tracetest package for the otelecho instrumentation. Do this in its own test module to not impose a dependency on the default SDK to the instrumentation user.

This uses a pre-release version of the sdk/trace/tracetest to prepare for the next release of otel-go.

Resolves #974

Part of open-telemetry/opentelemetry-go#2121

@MrAlias MrAlias added area: instrumentation Related to an instrumentation package Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Aug 13, 2021
@MrAlias MrAlias requested a review from XSAM as a code owner August 13, 2021 22:02
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #998 (e0168d4) into main (ec88a56) will increase coverage by 0.1%.
The diff coverage is 85.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #998     +/-   ##
=======================================
+ Coverage   74.9%   75.1%   +0.1%     
=======================================
  Files         71      76      +5     
  Lines       4462    4766    +304     
=======================================
+ Hits        3346    3580    +234     
- Misses       979    1036     +57     
- Partials     137     150     +13     
Impacted Files Coverage Δ
...ation/github.com/gocql/gocql/otelgocql/observer.go 75.1% <70.9%> (ø)
.../github.com/gocql/gocql/otelgocql/internal/cass.go 95.1% <95.1%> (ø)
...entation/github.com/gocql/gocql/otelgocql/gocql.go 100.0% <100.0%> (ø)
...ion/github.com/gocql/gocql/otelgocql/instrument.go 62.5% <100.0%> (ø)
...ntation/github.com/gocql/gocql/otelgocql/config.go 65.9% <0.0%> (ø)

@MrAlias MrAlias merged commit 7dabbfd into open-telemetry:main Aug 18, 2021
@MrAlias MrAlias deleted the otelgocql-oteltest branch August 18, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of oteltest in otelgocql
3 participants