Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of oteltest in otelgocql #974

Closed
8 tasks done
MrAlias opened this issue Aug 12, 2021 · 0 comments · Fixed by #998
Closed
8 tasks done

Remove use of oteltest in otelgocql #974

MrAlias opened this issue Aug 12, 2021 · 0 comments · Fixed by #998
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 12, 2021

  • Audit where the oteltest package is used.
  • Replace the use of the oteltest package TracerProvider with the trace.NewNoopTracerProvider where no span recording is necessary.
  • Move all remaining uses of the oteltest package for testing into a new test module.
    • Create a go.mod with a minimum Go version of 1.15.
    • Add a replace directive for any local contrib packages used in testing.
    • Add a doc.go with package documentation:

      /*
      Package test validates the <PACKAGE_NAME> instrumentation with the default SDK.
      This package is in a separate module from the instrumentation it tests to
      isolate the dependency of the default SDK and not impose this as a transitive
      dependency for users.
      */

  • Replace the use of the oteltest package SpanRecorder with the "go.opentelemetry.io/otel/sdk/trace/tracetest".SpanRecorder.
  • Refactor any remaining uses of the oteltest package away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant