Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-module test coverage #966

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Add cross-module test coverage #966

merged 3 commits into from
Aug 12, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Aug 12, 2021

Why

Per #897 (comment)

What

Add cross-module test coverage

Details

https://github.com/wadey/gocovmerge is used to merge lines like these:

go.opentelemetry.io/contrib/contrib.go:20.23,23.2 1 4
...
go.opentelemetry.io/contrib/contrib.go:20.23,23.2 1 1
...

into:

go.opentelemetry.io/contrib/contrib.go:20.23,23.2 1 204

Next PR

Do the same for https://github.com/open-telemetry/opentelemetry-go

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #966 (aa51148) into main (be914d3) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #966     +/-   ##
=======================================
+ Coverage   75.6%   75.7%   +0.1%     
=======================================
  Files         69      70      +1     
  Lines       4460    4467      +7     
=======================================
+ Hits        3372    3382     +10     
+ Misses       946     943      -3     
  Partials     142     142             
Impacted Files Coverage Δ
...mentation/github.com/gorilla/mux/otelmux/config.go 41.6% <0.0%> (-18.4%) ⬇️
contrib.go 100.0% <0.0%> (ø)
instrumentation/net/http/otelhttp/handler.go 81.1% <0.0%> (+4.1%) ⬆️

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MrAlias
Copy link
Contributor

MrAlias commented Aug 12, 2021

Planning to merge this before the 1 day policy as it doesn't touch the user facing code, only tooling, and will help give an accurate coverage report for things like #954.

@MrAlias MrAlias merged commit d65eb72 into open-telemetry:main Aug 12, 2021
@pellared pellared deleted the cross-module-test-coverage branch August 12, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants