-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove oteltest dependency from otelmux #897
Conversation
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
=======================================
- Coverage 75.6% 75.4% -0.3%
=======================================
Files 69 69
Lines 4458 4458
=======================================
- Hits 3374 3363 -11
- Misses 942 952 +10
- Partials 142 143 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactoring 😉
PS. Do we want to play with sth like https://github.com/ory/go-acc to more accurate code coverage results?
Yes! I was looking for something exactly like this. I think we should try to incorporate this. |
Replace the use of the
oteltest
package with thesdk/trace/tracetest
package for theotelmux
instrumentation. Do this in its owntest
module to not impose a dependency on the default SDK to the instrumentation user.This uses a pre-release version of the
sdk/trace/tracetest
to prepare for the next release of otel-go.Part of open-telemetry/opentelemetry-go#2121