Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oteltest dependency from otelmux #897

Merged
merged 6 commits into from
Aug 11, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 23, 2021

Replace the use of the oteltest package with the sdk/trace/tracetest package for the otelmux instrumentation. Do this in its own test module to not impose a dependency on the default SDK to the instrumentation user.

This uses a pre-release version of the sdk/trace/tracetest to prepare for the next release of otel-go.

Part of open-telemetry/opentelemetry-go#2121

@MrAlias MrAlias changed the title [proposal] New otelmux testing module Remove oteltest dependency from otelmux Aug 10, 2021
@MrAlias MrAlias added area: instrumentation Related to an instrumentation package Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Aug 10, 2021
@MrAlias MrAlias marked this pull request as ready for review August 10, 2021 22:44
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #897 (2339b3a) into main (05ba496) will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #897     +/-   ##
=======================================
- Coverage   75.6%   75.4%   -0.3%     
=======================================
  Files         69      69             
  Lines       4458    4458             
=======================================
- Hits        3374    3363     -11     
- Misses       942     952     +10     
- Partials     142     143      +1     
Impacted Files Coverage Δ
...mentation/github.com/gorilla/mux/otelmux/config.go 60.0% <0.0%> (-40.0%) ⬇️
...trumentation/github.com/gorilla/mux/otelmux/mux.go 81.4% <0.0%> (-8.7%) ⬇️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactoring 😉

PS. Do we want to play with sth like https://github.com/ory/go-acc to more accurate code coverage results?

More: https://www.ory.sh/golang-go-code-coverage-accurate/

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 11, 2021

nice refactoring

PS. Do we want to play with sth like https://github.com/ory/go-acc to more accurate code coverage results?

More: https://www.ory.sh/golang-go-code-coverage-accurate/

Yes! I was looking for something exactly like this. I think we should try to incorporate this.

@MrAlias MrAlias merged commit a73709b into open-telemetry:main Aug 11, 2021
@MrAlias MrAlias deleted the poc branch August 11, 2021 15:37
@MrAlias MrAlias mentioned this pull request Aug 12, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants