Add Macaron plugin #20
Conversation
|
Fixed docker-compose bug. |
MikeGoldsmith
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
Is someone available to review this PR please? All feedback welcome. |
Sorry about the delay. I was hoping to have #19 merged first to avoid having to review duplicate content. I'll see if I can't motivate more reviews on that to then prioritize this. |
* master: Runtime metrics plugin (open-telemetry#9) Fix issues raised by golangci-lint (open-telemetry#29) use correct circleci dir (open-telemetry#30) gorilla/mux instrumentation (open-telemetry#19) Update CODEOWNERS and CONTRIBUTING.md to match otel-go (open-telemetry#27) Dogstatsd exporter resource support (for 0.4.3 release) (open-telemetry#25) add datadog metrics exporter (open-telemetry#22) Update codeowners and maintainers (open-telemetry#21) # Conflicts: # go.mod # go.sum # internal/trace/http.go
|
I've addressed some of the feedback & merged master into my PR. I'll take a look at @krnowak's suggestion of a span name generator next. |
Accept the suggestion Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
@MikeGoldsmith This is looking great. I filed issue #37 so that we could merge it with a TODO. Would you mind updating for the 0.5.0 changes? Mostly it's that the "core" and "key" packages have been renamed/refactored. core-tracing things move into api/trace, and key/value stuff moves into api/kv. Thank you! |
/users/:idinstead of/users/123)I'm working on a bug in docker example, running examples/server.go works but wget from one container to another with server.go fails with lost context.
Copies internal mock span, tracer, etc from #15 & #19