Fix issues raised by golangci-lint #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These popped up when invoking `make`.
krnowak
requested review from
Aneurysm9,
jmacd,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
|
|
|
I just fixed our Circle config to automatically build this, can you amend and --force push it to make it update? |
jmacd
approved these changes
May 5, 2020
Aneurysm9
approved these changes
May 5, 2020
|
yeah, you'll need to integrate #30 in order to verify this fixes the build. |
|
Checks passed, is safe to merge. |
|
@lizthegrey : Thanks for handling this - I was busy reviewing mongo db PR at the time and haven't noticed your replies. Also, I assumed that CI was not yet set up. Good to know that I was wrong. |
MikeGoldsmith
added a commit
to MikeGoldsmith/opentelemetry-go-contrib
that referenced
this pull request
May 11, 2020
* master: Runtime metrics plugin (open-telemetry#9) Fix issues raised by golangci-lint (open-telemetry#29) use correct circleci dir (open-telemetry#30) gorilla/mux instrumentation (open-telemetry#19) Update CODEOWNERS and CONTRIBUTING.md to match otel-go (open-telemetry#27) Dogstatsd exporter resource support (for 0.4.3 release) (open-telemetry#25) add datadog metrics exporter (open-telemetry#22) Update codeowners and maintainers (open-telemetry#21) # Conflicts: # go.mod # go.sum # internal/trace/http.go
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These popped up when invoking
make.