Add Sql Collector (Part 2) #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Worked on PR feedback. Added unit tests.
CodeBlanch
requested review from
austinlparker,
bruno-garcia,
discostu105,
lmolkova,
MikeGoldsmith and
SergeyKanzhelev
as code owners
|
I tried to pick up all the remaining feedback on #355. The only thing I didn't do was rename SqlClientCollector->SqlClientAdapter. It just seemed weird having all the other stuff being mismatched. I figured it would be easier to do everything in one shot while working on #335, whenever that happens. |
CodeBlanch
commented
Mar 12, 2020
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinConversionExtensions.cs
Show resolved
Hide resolved
MikeGoldsmith
suggested changes
Mar 12, 2020
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinConversionExtensions.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerConversionExtensions.cs
Show resolved
Hide resolved
cijothomas
approved these changes
Mar 12, 2020
test/OpenTelemetry.Collector.Dependencies.Tests/SqlClientTests.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 12, 2020
src/OpenTelemetry.Collector.Dependencies/SqlClientCollectorOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Mar 12, 2020
MikeGoldsmith
suggested changes
Mar 13, 2020
src/OpenTelemetry.Collector.Dependencies/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
MikeGoldsmith
approved these changes
Mar 16, 2020
SergeyKanzhelev
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where @alexvaluyskiy left off on #355 adding a SqlCollector to OpenTelemetry.Collector.Dependencies.