Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry collector for Dapper #1355

Closed
andy-g opened this issue Oct 18, 2019 · 2 comments
Closed

OpenTelemetry collector for Dapper #1355

andy-g opened this issue Oct 18, 2019 · 2 comments

Comments

@andy-g
Copy link

andy-g commented Oct 18, 2019

Is there any plan to release an OpenTelemetry collector for Dapper?

OpenTelemetry (https://opentelemetry.io) is the next major version of the OpenTracing and OpenCensus projects, and it'd be awesome to have telemetry data automatically populated from dapper, especially as a major reason for using dapper is the performance advantage it gives over something like EFCore.
https://github.com/open-telemetry/opentelemetry-dotnet

There is already a collector for StackExchangeRedis (https://github.com/open-telemetry/opentelemetry-dotnet/tree/master/src/OpenTelemetry.Collector.StackExchangeRedis), so I'd be interested to know what would be involved in implementing something similar for dapper.

@NickCraver
Copy link
Member

There are no plans (from us) to implement this, but one way you could go about it is the same way MiniProfiler does it: by wrapping the DbConnection. See the ProfiledDb* classes in MiniProfiler. That approach works for any ADO.NET provider, but it looks like OpenTelemetry already did SqlServer specifically in: open-telemetry/opentelemetry-dotnet#536

Hope that answers the question!

@NickCraver
Copy link
Member

Closing this out to cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants