Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to Prometheus Exporter (ASP.NET Core) #3522

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 2, 2022

Changes

  • Changed the default cache duration from 10 seconds to 0.3 second (which is a good enough default for machine, and yet provide good interactive feedback to human).
  • Improved the docs.

Given this is a fairly small change on the not-yet-released package, I didn't include a changelog entry.

@reyang reyang requested a review from a team August 2, 2022 23:19
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #3522 (bb06572) into main (27658f0) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   86.79%   86.73%   -0.07%     
==========================================
  Files         275      275              
  Lines        9958     9958              
==========================================
- Hits         8643     8637       -6     
- Misses       1315     1321       +6     
Impacted Files Coverage Δ
...Prometheus.AspNetCore/PrometheusExporterOptions.cs 50.00% <100.00%> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️

@cijothomas cijothomas merged commit 2821898 into open-telemetry:main Aug 3, 2022
@reyang reyang deleted the reyang/prometheus-minor-changes branch August 6, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants