Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter cache duration set to 300ms #1271

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Prometheus exporter cache duration set to 300ms #1271

merged 3 commits into from
Sep 23, 2022

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 23, 2022 •
edited
Loading

Why

Include settings value from: open-telemetry/opentelemetry-dotnet#3522

  • same settings as the newest version of OTel SDK.
  • It should improve CI stability.

What

Prometheus exporter cache duration set to 300ms
it is backport from OTel SDK 1.4.0

Tests

CI

Checklist

  • [ ] CHANGELOG.md is updated.
  • [ ] Documentation is updated.
  • [ ] New features are covered by tests.

@Kielek
Prometheus exporter cache duration set to 300ms
3decedb 
it is backport from OTel SDK 1.4.0
@Kielek Kielek requested a review from a team September 23, 2022 08:44
pellared
pellared approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this change I suggest changing the interval in PrometheusExporter test to 1 sec so it can succeed faster

@rajkumar-rangaraj rajkumar-rangaraj enabled auto-merge (squash) September 23, 2022 18:18
@rajkumar-rangaraj rajkumar-rangaraj merged commit cadccf4 into open-telemetry:main Sep 23, 2022
@Kielek Kielek deleted the prometheus-exporter-300ms-cache branch September 23, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RassK RassK RassK approved these changes

@pellared pellared pellared approved these changes

@pjanotti pjanotti pjanotti approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@dszmigielski dszmigielski dszmigielski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kielek @RassK @pellared @pjanotti @rajkumar-rangaraj @dszmigielski