Make StartupLogger more resilient #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
approved these changes
Jan 11, 2023
xiang17
reviewed
Jan 11, 2023
Kielek
approved these changes
Jan 12, 2023
pellared
reviewed
Jan 17, 2023
pellared
reviewed
Jan 17, 2023
test/test-applications/integrations/TestApplication.MultipleAppDomains.NetFramework/Program.cs
Show resolved
Hide resolved
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The StartupLogger can hit errors when used.
Fixes #1885
What
The StartupLogger was made more resilient by adding the capability to handle the following cases:
AppDomainfriendly name is repeated - this is done by adding theAppDomain.Idto the log file name.AppDomainfriendly name has invalid chars for a file name - these chars are replaced by an underscore.Tests
Added a dedicated tests to exercise the new capabilities.
Checklist
CHANGELOG.mdis updated.- [ ] Documentation is updated.