Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential small optimization to StartupLogger #1997

Closed
pjanotti opened this issue Jan 18, 2023 · 1 comment · Fixed by #2067
Closed

Potential small optimization to StartupLogger #1997

pjanotti opened this issue Jan 18, 2023 · 1 comment · Fixed by #2067
Assignees
@xiang17
Labels
good first issue Good for newcomers help wanted Extra attention is needed performance
Milestone
0.6.0

Comments

@pjanotti
Copy link
Contributor

Per @pellared comment we should benchmark and consider if it is worth changing the code. The benchmark should include the time to create and insert the data into the type used to clean up the invalid chars.
@pjanotti pjanotti mentioned this issue Jan 18, 2023
Merged
2 tasks
@pjanotti pjanotti added this to the post-1.0.0 milestone Jan 18, 2023
@Kielek Kielek added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 18, 2023
@xiang17
Copy link
Contributor

xiang17 commented Jan 24, 2023

I'm working on adding a Benchmark for this. Can you assign this to me?

@xiang17 xiang17 mentioned this issue Jan 24, 2023
Merged
@Kielek Kielek modified the milestones: post-1.0.0, 0.6.0 Jan 24, 2023
@xiang17 xiang17 mentioned this issue Apr 13, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiang17 xiang17

Labels
good first issue Good for newcomers help wanted Extra attention is needed performance
Projects
OpenTelemetry .NET Automatic Instrumentation
Archived in project
Milestone
0.6.0
4 participants
@pellared @pjanotti @Kielek @xiang17