-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AspNet] pass http.request.method to sampler #2023
Open
roycald245
wants to merge
26
commits into
open-telemetry:main
Choose a base branch
from
roycald245:feat/add-http-method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
961e5be
add http.method to create activity
roycald245 993d7bc
test
roycald245 29fbce7
remove comment
roycald245 9078fe8
Merge branch 'main' into feat/add-http-method
roycald245 353d9d6
edit changelog
roycald245 d6d0942
edit readme
roycald245 dce0aac
update tests
roycald245 d2e511e
lint
roycald245 8855fd1
lint markdown
roycald245 f62e71c
fix passing url.path to http.request.method
roycald245 4c3c59a
Edit changelog
roycald245 114cabb
rephrase changelog
roycald245 8494e65
Update CHANGELOG.md
roycald245 36496b0
lint changelog
roycald245 606b118
Merge branch 'main' into feat/add-http-method
Kielek 34e7fa3
Add http method normalization
roycald245 128ac4a
Merge branch 'main' into feat/add-http-method
roycald245 ae37251
Merge branch 'main' into feat/add-http-method
roycald245 4ea758b
Merge branch 'main' into feat/add-http-method
cijothomas b56b68f
allow RequestDataHelper configuration by environment variable
roycald245 b1cdc34
Revert allow environment configuration of RequestDataHelper
roycald245 06d8c26
Merge branch 'main' into feat/add-http-method
roycald245 7498fde
Revert revert of requestDataHelper parameter
roycald245 1c59dd0
Merge branch 'main' into feat/add-http-method
Kielek 1241783
Merge branch 'main' into feat/add-http-method
roycald245 4c0f465
Merge branch 'main' into feat/add-http-method
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not replace
KeyValuePair<string, object?>[]?
withList<KeyValuePair<string, object?>>?
for dynamic tag management, which eliminates the need for manual index handling in arrays, making the code more flexible and cleaner?