[Instrumentation.AspNet] pass http.request.method to sampler #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.aspnet.telemetryhttpmodule
github-actions
bot
added
comp:instrumentation.aspnet
Kielek
reviewed
Aug 26, 2024
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/ActivityHelper.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Aug 26, 2024
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Aug 26, 2024
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Kielek
changed the title
Kielek
reviewed
Aug 27, 2024
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
| { | ||
| tags = cachedTagsStorage ??= new KeyValuePair<string, object?>[1]; | ||
| string? path = context.Request?.Unvalidated?.Path; | ||
| string? method = context.Request?.HttpMethod; |
There was a problem hiding this comment.
I think we need to set the normalized value as we do here
If the method is normalized to _OTHER then should we also include http.request.method_original, that part is not very clear in spec
There was a problem hiding this comment.
I think setting "HTTP" like the example you sent is the way to go. Keeping the convention.
Kielek
reviewed
Sep 6, 2024
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/ActivityHelper.cs
Outdated
Show resolved
Hide resolved
|
@cijothomas @Kielek this would be really useful for us.... can we have it available sooner |
| @@ -64,22 +65,38 @@ public static bool HasStarted(HttpContext context, out Activity? aspNetActivity) | |||
| PropagationContext propagationContext = textMapPropagator.Extract(default, context.Request, HttpRequestHeaderValuesGetter); | |||
|
|
|||
| KeyValuePair<string, object?>[]? tags; | |||
There was a problem hiding this comment.
Why not replace KeyValuePair<string, object?>[]? with List<KeyValuePair<string, object?>>? for dynamic tag management, which eliminates the need for manual index handling in arrays, making the code more flexible and cleaner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57287
Changes
Added http.request.method to tags given to sampler
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes