Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trace] Add SpanData getter for Span Recordable #1508

Merged
merged 11 commits into from
Aug 2, 2022
Merged

[Trace] Add SpanData getter for Span Recordable #1508

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dfa0102
add recordable span_data getter
lalitb Jul 20, 2022
eac517b
fix
lalitb Jul 20, 2022
67ad7c7
fix
lalitb Jul 20, 2022
f7dc7bc
remove circular dependency
lalitb Jul 20, 2022
1142329
Merge branch 'main' into recordable-spandata
lalitb Jul 21, 2022
55c9140
Merge branch 'main' into recordable-spandata
lalitb Jul 25, 2022
5f8abf4
Merge branch 'main' into recordable-spandata
ThomsonTan Jul 27, 2022
3d8ccf9
Merge branch 'main' into recordable-spandata
lalitb Jul 28, 2022
ee1b530
Merge branch 'main' into recordable-spandata
ThomsonTan Aug 1, 2022
dbfd7eb
formatting..
lalitb Aug 1, 2022
fdcc018
Merge branch 'main' into recordable-spandata
lalitb Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sdk/include/opentelemetry/sdk/trace/recordable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace trace
{

using namespace opentelemetry::sdk::instrumentationlibrary;

class SpanData;
/**
* Maintains a representation of a span in a format that can be processed by a recorder.
*
Expand Down Expand Up @@ -146,6 +146,14 @@ class Recordable
*/
virtual void SetInstrumentationLibrary(
const InstrumentationLibrary &instrumentation_library) noexcept = 0;

/**
* Get the SpanData object for this Recordable.
*
* @return SpanData*
*/

virtual explicit operator SpanData *() const { return nullptr; }
};
} // namespace trace
} // namespace sdk
Expand Down