[Trace] Add SpanData getter for Span Recordable #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
+ Coverage 84.59% 84.63% +0.05%
==========================================
Files 156 156
Lines 4794 4795 +1
==========================================
+ Hits 4055 4058 +3
+ Misses 739 737 -2
|
|
@lalitb This suffices my need. Nice work! |
ThomsonTan
approved these changes
Jul 27, 2022
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1475
Changes
Add SpanData getter interface for Recordable, as discussed in #1475. This allows for writing the custom processor to filter the spans based on the span attributes/properties not available during span creation.
We still need to write the actual implementation of this interface for the exporters, but this is not the scope of this PR. The contributions are welcome to implement separately.
@luyor - would this suffice your requirement.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes