Don't move a constant AttributeValue #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 93.75% 94.11% +0.36%
==========================================
Files 74 74
Lines 1792 1802 +10
==========================================
+ Hits 1680 1696 +16
+ Misses 112 106 -6
|
pyohannes
force-pushed
the
const-attribute-value
branch
2 times, most recently
from
637bf1d
to
0e25607
Compare
maxgolov
approved these changes
Jul 10, 2020
pyohannes
force-pushed
the
const-attribute-value
branch
from
2597ec8
to
1438b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a constant object causes a copy to be made. Let's rather pass a reference.
Related to this comment.