Increase coverage

open-telemetry · Jul 9, 2020 · 2597ec8 · 2597ec8
1 parent 0e25607
commit 2597ec8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/api/test/trace/noop_test.cc b/api/test/trace/noop_test.cc
@@ -25,4 +25,6 @@ TEST(NoopTest, UseNoopTracers)
 
   std::vector<std::pair<std::string, std::vector<int>>> attributes3;
   s1->AddEvent("abc", attributes3);
+
+  s1->SetAttribute("abc", 4);
 }
diff --git a/sdk/test/trace/tracer_test.cc b/sdk/test/trace/tracer_test.cc
@@ -1,7 +1,7 @@
 #include "opentelemetry/sdk/trace/tracer.h"
-#include "opentelemetry/sdk/trace/simple_processor.h"
-#include "opentelemetry/sdk/trace/samplers/always_on.h"
 #include "opentelemetry/sdk/trace/samplers/always_off.h"
+#include "opentelemetry/sdk/trace/samplers/always_on.h"
+#include "opentelemetry/sdk/trace/simple_processor.h"
 #include "opentelemetry/sdk/trace/span_data.h"
 
 #include <gtest/gtest.h>
@@ -142,7 +142,6 @@ TEST(Tracer, StartSpanWithAttributes)
   ASSERT_EQ(3.0, nostd::get<double>(span_data2->GetAttributes().at("attr3")));
 }
 
-
 TEST(Tracer, GetSampler)
 {
   // Create a Tracer with a default AlwaysOnSampler
@@ -154,8 +153,25 @@ TEST(Tracer, GetSampler)
 
   // Create a Tracer with a AlwaysOffSampler
   std::shared_ptr<SpanProcessor> processor_2(new SimpleSpanProcessor(nullptr));
-  std::shared_ptr<Tracer> tracer_off(new Tracer(std::move(processor_2), std::make_shared<AlwaysOffSampler>()));
+  std::shared_ptr<Tracer> tracer_off(
+      new Tracer(std::move(processor_2), std::make_shared<AlwaysOffSampler>()));
 
   auto t2 = tracer_off->GetSampler();
   ASSERT_EQ("AlwaysOffSampler", t2->GetDescription());
 }
+
+TEST(Tracer, SpanSetAttribute)
+{
+  std::shared_ptr<std::vector<std::unique_ptr<SpanData>>> spans_received(
+      new std::vector<std::unique_ptr<SpanData>>);
+  auto tracer = initTracer(spans_received);
+
+  auto span = tracer->StartSpan("span 1");
+
+  span->SetAttribute("abc", 3.1);
+
+  span->End();
+  ASSERT_EQ(1, spans_received->size());
+  auto &span_data = spans_received->at(0);
+  ASSERT_EQ(3.1, nostd::get<double>(span_data->GetAttributes().at("abc")));
+}