Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent starting unnecessary goroutines #9817

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bogdandrutu
Copy link
Member

Fixes #9739
Replaces #9814

@bogdandrutu bogdandrutu requested review from a team and djaglowski March 22, 2024 16:14
@bogdandrutu bogdandrutu force-pushed the unnecessary-goroutines branch 2 times, most recently from d394eb0 to 3abbbf5 Compare March 22, 2024 16:23
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (2037527) to head (291c9fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9817   +/-   ##
=======================================
  Coverage   91.12%   91.13%           
=======================================
  Files         353      353           
  Lines       18723    18728    +5     
=======================================
+ Hits        17062    17067    +5     
  Misses       1333     1333           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 15201f1 into open-telemetry:main Mar 22, 2024
48 checks passed
@bogdandrutu bogdandrutu deleted the unnecessary-goroutines branch March 22, 2024 16:55
@github-actions github-actions bot added this to the next release milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When multiple goroutine calls consume, mb.newShard(md) will be called multiple times.
2 participants