Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/batch] prevent potential goroutine leak #9814

Conversation

andrzej-stencel
Copy link
Member

Fixes #9739

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (2037527) to head (c0ca175).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9814   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         353      353           
  Lines       18723    18723           
=======================================
  Hits        17062    17062           
  Misses       1333     1333           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bogdandrutu added a commit that referenced this pull request Mar 22, 2024
Fixes
#9739
Replaces
#9814

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@andrzej-stencel andrzej-stencel deleted the fix-batch-processor-goroutine-leak branch May 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When multiple goroutine calls consume, mb.newShard(md) will be called multiple times.
3 participants