Combine UTs for the collector builder #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Codecov ReportBase: 90.65% // Head: 90.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
=======================================
Coverage 90.65% 90.65%
=======================================
Files 241 241
Lines 14518 14518
=======================================
Hits 13161 13161
Misses 1089 1089
Partials 268 268 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Aneurysm9
approved these changes
Jan 20, 2023
bogdandrutu
approved these changes
Jan 20, 2023
bogdandrutu
added
the
Skip Changelog
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 23, 2023
Signed-off-by: Raphael Silva <rapphil@gmail.com> Signed-off-by: Raphael Silva <rapphil@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Combine UTs of the builder so that they work properly.TestGenerateAndCompileWithDebugCompilationwas not replacing all modules and therefore the tests were failing in case there were changes in some components in the local file system. This change will solve this failure in #6683: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/3952660827/jobs/6768024904#step:6:25Combine builder UTs so that we avoid code duplication when changing/modifying components or adding new compilation scenarios.
Omitting new entry in the change log since this is only improving the UTs.