Add the httpsprovider component #6683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
changed the title
Codecov ReportBase: 90.38% // Head: 90.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6683 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 243 245 +2
Lines 14575 14638 +63
=======================================
+ Hits 13173 13230 +57
- Misses 1133 1139 +6
Partials 269 269
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Having read through the code a bit, I would prefer the optional settings to be configurable via flags like:
otelcol --tls-ca-cert-path=file://infra/testinfra:named=testenv
--tls-ca-cert-path=file://infra/prodinfra:named=prodenv
--config=https://internal.infra.io/config:tls-bundle=testenv
However, I am not sure how feasible that might be.
Aneurysm9
reviewed
Dec 27, 2022
|
From the SIG, let's have a first PR with an https provider without any configurable parameters and move the discussion on how to configure a confmap provider to an issue. |
rapphil
force-pushed
the
rapphil-add-https-confimap
branch
from
04bc6e3 to
9d3e66a
Compare
rapphil
changed the title
rapphil
force-pushed
the
rapphil-add-https-confimap
branch
from
29723df to
9d804d8
Compare
rapphil
requested review from
Aneurysm9,
MovieStoreGuy and
bryan-aguilar
and removed request for
jpkrohling,
Aneurysm9 and
MovieStoreGuy
mx-psi
reviewed
Jan 10, 2023
rapphil
force-pushed
the
rapphil-add-https-confimap
branch
from
86c1fcd to
9ba23b0
Compare
rapphil
requested review from
Aneurysm9
and removed request for
bryan-aguilar
mx-psi
reviewed
Jan 16, 2023
confmap/provider/internal/configurablehttpprovider/provider_test.go
Outdated
Show resolved
Hide resolved
mx-psi
approved these changes
Jan 17, 2023
Aneurysm9
approved these changes
Jan 17, 2023
rapphil
force-pushed
the
rapphil-add-https-confimap
branch
from
ca7e6be to
f01173e
Compare
Aneurysm9
added
the
ready-to-merge
|
@codeboten, @bogdandrutu and @dmitryax, is there anything that I can do to get this merged? |
bogdandrutu
reviewed
Jan 24, 2023
Add the httpsprovider component that allows the collector to fetch configuration from a web server using the https protocol. Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Improve unit tests to check for error while parsing test URL. Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
rapphil
force-pushed
the
rapphil-add-https-confimap
branch
from
f01173e to
0adcd04
Compare
Signed-off-by: Raphael Silva <rapphil@gmail.com>
rapphil
requested review from
bogdandrutu
and removed request for
MovieStoreGuy and
bryan-aguilar
bogdandrutu
reviewed
Jan 24, 2023
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
bogdandrutu
approved these changes
Jan 25, 2023
Signed-off-by: Raphael Silva <rapphil@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add the httpsprovider component that allows the collector to load configuration from HTTP servers using the HTTPS protocol.
This PR is based on this work junhaoyu-aws#4
A bit of refactoring was made and an internal configurablehttpprovider was created. This component is used by both the httpsprovider and the httpprovider. The only difference is the configuration of the transport layer.
Testing: Unit tests using httptest and self signed certificates were added.
Documentation: A readme was added for the httpsprovider component.