-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Factories to otelcol, delete otelcoltest #6792
Move Factories to otelcol, delete otelcoltest #6792
Conversation
bf76364
to
600bc6c
Compare
Codecov ReportBase: 90.12% // Head: 90.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6792 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 250 250
Lines 14333 14333
=======================================
Hits 12918 12918
Misses 1165 1165
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
600bc6c
to
e6471d4
Compare
e6471d4
to
230c661
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting some deletions in the service package of the things you just added.
|
Resolves #6766
NopFactories
is moved tootelcoltest
. However,otelcol
has its own private implementation in order to avoid a dependency cycle.