Move Factories to otelcol, delete otelcoltest #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
mv-factories-otelcol
branch
from
bf76364
to
600bc6c
Compare
Codecov ReportBase: 90.12% // Head: 90.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6792 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 250 250
Lines 14333 14333
=======================================
Hits 12918 12918
Misses 1165 1165
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
mv-factories-otelcol
branch
from
600bc6c
to
e6471d4
Compare
djaglowski
force-pushed
the
mv-factories-otelcol
branch
from
e6471d4
to
230c661
Compare
bogdandrutu
reviewed
Dec 13, 2022
|
|
|
Where?
|
|
These are all the files in this PR (at least this is what I see)
|
|
These files were moved from
|
bogdandrutu
approved these changes
Dec 13, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6766
NopFactoriesis moved tootelcoltest. However,otelcolhas its own private implementation in order to avoid a dependency cycle.