Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper division between "service" & "otelcol" packages #6766

Closed
djaglowski opened this issue Dec 12, 2022 · 1 comment · Fixed by #6792
Closed

Proper division between "service" & "otelcol" packages #6766

djaglowski opened this issue Dec 12, 2022 · 1 comment · Fixed by #6792

Comments

@djaglowski
Copy link
Member

djaglowski commented Dec 12, 2022

In #6723, I attempted to move component.Factories and componenttest.NopFactories to otelcol and otelcoltest, respectively. However, I was not able to identify a clear separation point between service and otelcol packages.

Additional context: #6723 (comment)

The immediate problems are:

  1. Both otelcol and service contain many references to Factories.
  2. otelcol contains many references to service.

Therefore, Factories can exist in service without causing import cycles, but the opposite is not true.

In order to move Factories to otelcol, we must determine which of the two points above should change. Should otelcol not depend on service, or should service not depend on Factories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants