Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[config{grpc,http}] Add warning when using unspecified address (#6267)" #6405

Conversation

codeboten
Copy link
Contributor

This reverts commit 396964d.

@codeboten codeboten requested review from a team and bogdandrutu October 25, 2022 19:22
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 91.40% // Head: 91.43% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (f64d4ab) compared to base (71e6952).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6405      +/-   ##
==========================================
+ Coverage   91.40%   91.43%   +0.02%     
==========================================
  Files         236      235       -1     
  Lines       13478    13454      -24     
==========================================
- Hits        12319    12301      -18     
+ Misses        935      931       -4     
+ Partials      224      222       -2     
Impacted Files Coverage Δ
config/configgrpc/configgrpc.go 87.98% <ø> (+1.06%) ⬆️
config/confighttp/confighttp.go 100.00% <ø> (+1.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten
Copy link
Contributor Author

Reverting this change as it causes a breaking change preventing users from entering :6060 as their endpoint configuration. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3323429895/jobs/5493782699#step:8:921 for failure

@codeboten codeboten merged commit 36d142f into open-telemetry:main Oct 25, 2022
@codeboten codeboten deleted the codeboten/rollback-396964d8cfac89cc126901f4b1590bea7b69817b branch October 26, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants