Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update collector/exporter dependencies #15657

Merged
merged 10 commits into from
Oct 26, 2022

Conversation

codeboten
Copy link
Contributor

This supports the split of otlp/otlphttp/logging exporters. It required a change to update-dep script.

Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working through the failures

@codeboten
Copy link
Contributor Author

Was blocked by open-telemetry/opentelemetry-collector#6405, updating otel once more now

@codeboten
Copy link
Contributor Author

There's a test failing in the datadogexporter, @mx-psi if you can confirm that it's ok for me to set and environment variable for this test to pass, please review 3a5b446

Failing test, I believe this is caused by the quick failure on validation:

--- FAIL: TestExamples (0.01s)
    --- FAIL: TestExamples/collector.yaml (0.00s)
        examples_test.go:55: 
                Error Trace:    /Users/alex.boten/workspace/opentelemetry-collector-contrib/exporter/datadogexporter/examples_test.go:55
                Error:          Received unexpected error:
                                exporter "datadog" has invalid configuration: api.key is not set
                Test:           TestExamples/collector.yaml
                Messages:       All yaml config must validate. Please ensure that all necessary component factories are added in newTestComponents()

@mx-psi
Copy link
Member

mx-psi commented Oct 26, 2022

There are more tests failing on the receivercreator:

 === RUN   TestInvalidResourceAttributeEndpointType
    config_test.go:142: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/receivercreator/config_test.go:142
        	Error:      	Error message not equal:
        	            	expected: "error reading receivers configuration for \"receiver_creator\": resource attributes for unsupported endpoint type \"not.a.real.type\""
        	            	actual  : "cannot unmarshal the configuration: error reading top level configuration sections: 1 error(s) decoding:\n\n* error decoding 'receivers': error reading receivers configuration for \"receiver_creator\": resource attributes for unsupported endpoint type \"not.a.real.type\""
        	Test:       	TestInvalidResourceAttributeEndpointType
--- FAIL: TestInvalidResourceAttributeEndpointType (0.01s)

@codeboten
Copy link
Contributor Author

There are more tests failing on the receivercreator:

 === RUN   TestInvalidResourceAttributeEndpointType
    config_test.go:142: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/receivercreator/config_test.go:142
        	Error:      	Error message not equal:
        	            	expected: "error reading receivers configuration for \"receiver_creator\": resource attributes for unsupported endpoint type \"not.a.real.type\""
        	            	actual  : "cannot unmarshal the configuration: error reading top level configuration sections: 1 error(s) decoding:\n\n* error decoding 'receivers': error reading receivers configuration for \"receiver_creator\": resource attributes for unsupported endpoint type \"not.a.real.type\""
        	Test:       	TestInvalidResourceAttributeEndpointType
--- FAIL: TestInvalidResourceAttributeEndpointType (0.01s)

who knew we had so many invalid tests 😆

@codeboten codeboten merged commit 6037705 into open-telemetry:main Oct 26, 2022
@codeboten codeboten deleted the codeboten/update-otel-oct24 branch October 26, 2022 16:18
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
This change required:

- NewJSONUnmarshaler -> JSONUnmarshaler
- NewProtoUnmarshaler -> ProtoUnmarshaler
- NewClient -> NewGRPCClient
- split of otlp/otlphttp/logging exporters
  - change to update-dep script.
- updated tests that were looking for specific error messages
- updated tests that were setting an invalid endpoint
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants