-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update collector/exporter dependencies #15657
[chore] update collector/exporter dependencies #15657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working through the failures
Was blocked by open-telemetry/opentelemetry-collector#6405, updating otel once more now |
72d4fcc
to
40b6307
Compare
There's a test failing in the datadogexporter, @mx-psi if you can confirm that it's ok for me to set and environment variable for this test to pass, please review 3a5b446 Failing test, I believe this is caused by the quick failure on validation:
|
NewJSONUnmarshaler -> JSONUnmarshaler NewProtoUnmarshaler -> ProtoUnmarshaler NewClient -> NewGRPCClient
5004115
to
a0bb7bf
Compare
There are more tests failing on the
|
who knew we had so many invalid tests 😆 |
This change required: - NewJSONUnmarshaler -> JSONUnmarshaler - NewProtoUnmarshaler -> ProtoUnmarshaler - NewClient -> NewGRPCClient - split of otlp/otlphttp/logging exporters - change to update-dep script. - updated tests that were looking for specific error messages - updated tests that were setting an invalid endpoint
This supports the split of otlp/otlphttp/logging exporters. It required a change to
update-dep
script.