Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all StringKeyValue non-nullable #2019

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Make all StringKeyValue non-nullable #2019

merged 2 commits into from
Oct 27, 2020

Commits on Oct 27, 2020

  1. Make all StringKeyValue non-nullable 

    Add benchmarks for logs and metrics similar to traces.

Before:

```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/consumer/pdata
BenchmarkMetricsFromOtlp
BenchmarkMetricsFromOtlp-16    	     298	   3999204 ns/op	 2424909 B/op	   70785 allocs/op
PASS
```

After:

```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/consumer/pdata
BenchmarkMetricsFromOtlp
BenchmarkMetricsFromOtlp-16    	     326	   3630227 ns/op	 2271248 B/op	   51577 allocs/op
PASS
```

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    cd2b099 View commit details
    Browse the repository at this point in the history

  2. Update consumer/pdata/common_test.go 

    Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
    @bogdandrutu @tigrannajaryan
    bogdandrutu and tigrannajaryan authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5164d65 View commit details
    Browse the repository at this point in the history