-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all StringKeyValue non-nullable #2019
Conversation
Add benchmarks for logs and metrics similar to traces. Before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 298 3999204 ns/op 2424909 B/op 70785 allocs/op PASS ``` After: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 326 3630227 ns/op 2271248 B/op 51577 allocs/op PASS ``` Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@@ -273,7 +273,6 @@ genproto_sub: | |||
@echo Modify them in the intermediate directory. | |||
$(foreach file,$(OPENTELEMETRY_PROTO_FILES),$(call exec-command,sed -f proto_patch.sed $(OPENTELEMETRY_PROTO_SRC_DIR)/$(file) > $(PROTO_INTERMEDIATE_DIR)/$(file))) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of merge :(
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 91.88% 91.90% +0.02%
==========================================
Files 276 276
Lines 16462 16461 -1
==========================================
+ Hits 15126 15129 +3
+ Misses 921 919 -2
+ Partials 415 413 -2
Continue to review full report at Codecov.
|
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Add benchmarks for logs and metrics similar to traces.
Before:
After: