Make all StringKeyValue non-nullable #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add benchmarks for logs and metrics similar to traces. Before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 298 3999204 ns/op 2424909 B/op 70785 allocs/op PASS ``` After: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 326 3630227 ns/op 2271248 B/op 51577 allocs/op PASS ``` Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
commented
Oct 27, 2020
| @@ -273,7 +273,6 @@ genproto_sub: | |||
| @echo Modify them in the intermediate directory. | |||
| $(foreach file,$(OPENTELEMETRY_PROTO_FILES),$(call exec-command,sed -f proto_patch.sed $(OPENTELEMETRY_PROTO_SRC_DIR)/$(file) > $(PROTO_INTERMEDIATE_DIR)/$(file))) | |||
|
|
|||
|
|
|||
tigrannajaryan
approved these changes
Oct 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 91.88% 91.90% +0.02%
==========================================
Files 276 276
Lines 16462 16461 -1
==========================================
+ Hits 15126 15129 +3
+ Misses 921 919 -2
+ Partials 415 413 -2
Continue to review full report at Codecov.
|
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks for logs and metrics similar to traces.
Before:
After: