Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper receiver factory to reduce boilerplate #1334

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 13, 2020

Alternative for #1333

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1334 into master will increase coverage by 0.02%.
The diff coverage is 92.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
+ Coverage   89.76%   89.79%   +0.02%     
==========================================
  Files         214      215       +1     
  Lines       15138    15155      +17     
==========================================
+ Hits        13589    13608      +19     
+ Misses       1132     1131       -1     
+ Partials      417      416       -1     
Impacted Files Coverage Δ
receiver/hostmetricsreceiver/factory.go 83.67% <77.77%> (-3.63%) ⬇️
receiver/jaegerreceiver/factory.go 94.30% <92.10%> (+1.56%) ⬆️
receiver/otlpreceiver/factory.go 88.73% <100.00%> (+3.22%) ⬆️
receiver/receiverhelper/factory.go 100.00% <100.00%> (ø)
service/defaultcomponents/defaults.go 83.67% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab1561...5bcb38d. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the componenthelper branch 2 times, most recently from 2c5915c to 9e82533 Compare July 13, 2020 23:35
@bogdandrutu bogdandrutu changed the title Add helper component to reduce boilerplate Add helper receiver factory to reduce boilerplate Jul 14, 2020
@bogdandrutu bogdandrutu force-pushed the componenthelper branch 3 times, most recently from da44384 to 4f87bfa Compare July 14, 2020 04:13
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 2195bbc into open-telemetry:master Jul 14, 2020
@bogdandrutu bogdandrutu deleted the componenthelper branch July 14, 2020 04:32
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* add opencensus binary propagation bridge

* Update bridge/opencensus/binary/binary.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update bridge/opencensus/doc.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* address comments

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
open-telemetry#1353)

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
* Update examples for v1beta1

fixes open-telemetry#1333

* bump minor version and run generate-examples

is this really what they want me to do?

* bump the patch version, not the minor version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants