Add Metrics Only Receiver Factory type #1333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is kind of annoying to have to define a boilerplate method for traces when it has nothing to do with the receiver.
keitwb
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 89.76% 89.79% +0.02%
==========================================
Files 214 214
Lines 15138 15138
==========================================
+ Hits 13589 13593 +4
+ Misses 1132 1128 -4
Partials 417 417
Continue to review full report at Codecov.
|
|
Probably we can use options pattern to allow users to set optional params like the custom marshaler and reduce the signature for the New funcs. |
|
@bogdandrutu yeah what you did seems pretty flexible long term. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add parent context to SpanProcessor.OnStart The spec requires doing so. Right now SpanProcessor implementations aren't doing anything with this argument. * Update changelog * Fix typo in test name
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Update examples for v1beta1 fixes open-telemetry#1333 * bump minor version and run generate-examples is this really what they want me to do? * bump the patch version, not the minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is kind of annoying to have to define a boilerplate method for traces when
it has nothing to do with the receiver.