-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics Only Receiver Factory type #1333
Conversation
It is kind of annoying to have to define a boilerplate method for traces when it has nothing to do with the receiver.
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 89.76% 89.79% +0.02%
==========================================
Files 214 214
Lines 15138 15138
==========================================
+ Hits 13589 13593 +4
+ Misses 1132 1128 -4
Partials 417 417
Continue to review full report at Codecov.
|
Probably we can use options pattern to allow users to set optional params like the custom marshaler and reduce the signature for the New funcs. |
@bogdandrutu yeah what you did seems pretty flexible long term. |
* Add parent context to SpanProcessor.OnStart The spec requires doing so. Right now SpanProcessor implementations aren't doing anything with this argument. * Update changelog * Fix typo in test name
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
* Update examples for v1beta1 fixes open-telemetry#1333 * bump minor version and run generate-examples is this really what they want me to do? * bump the patch version, not the minor version
It is kind of annoying to have to define a boilerplate method for traces when
it has nothing to do with the receiver.