[chore]: Deprecate and remove NewUnhealthyProcessorCreateSettings #11384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11384 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 432 432
Lines 20425 20425
=======================================
Hits 18750 18750
Misses 1301 1301
Partials 374 374 ☔ View full report in Codecov by Sentry. |
songy23
reviewed
Oct 7, 2024
| component: processortest | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Deprecate and remove processortest.NewUnhealthyProcessorCreateSettings |
There was a problem hiding this comment.
Suggested change
| note: Deprecate and remove processortest.NewUnhealthyProcessorCreateSettings | |
| note: Deprecate processortest.NewUnhealthyProcessorCreateSettings |
this isn't removed yet
songy23
approved these changes
Oct 7, 2024
|
Hey, unfortunately we had #11376 before. Please do not hesitate to send more PRs, we discussed and applied the rule of the first PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate NewUnhealthyProcessorCreateSettings
Link to tracking issue
Fixes #11307
Testing
Documentation