Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11307- Deprecate and remove processorhelper.NewUnhealthyProcessorCreateSettings #11376

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

olamideTiana
Copy link
Contributor

@olamideTiana olamideTiana commented Oct 6, 2024

Deprecate and remove NewUnhealthyProcessorCreateSettings

Fixes #11307

@olamideTiana olamideTiana reopened this Oct 6, 2024
@olamideTiana
Copy link
Contributor Author

olamideTiana commented Oct 6, 2024

Deprecated and remove func NewUnhealthyProcessorCreateSettings @bogdandrutu Please kindly review

@olamideTiana olamideTiana reopened this Oct 6, 2024
Copy link
Contributor Author

@olamideTiana olamideTiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codeboten
Copy link
Contributor

codeboten commented Oct 7, 2024

updated the description to automatically close the related issue

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment and changelog needs updating

processor/processortest/unhealthy_processor.go Outdated Show resolved Hide resolved
.chloggen/processortest-deprecated-removed-func.yaml Outdated Show resolved Hide resolved
.chloggen/processortest-deprecated-removed-func.yaml Outdated Show resolved Hide resolved
bogdandrutu and others added 3 commits October 7, 2024 15:35
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (b06236c) to head (5e50970).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11376   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         430      430           
  Lines       20311    20311           
=======================================
  Hits        18671    18671           
  Misses       1267     1267           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 8bc3eae into open-telemetry:main Oct 8, 2024
52 of 53 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove processorhelper.NewUnhealthyProcessorCreateSettings
4 participants