adding tests

model/otlp/pb_test.go

@@ -81,6 +81,29 @@ func TestProtobufMetricsSizer_withNil(t *testing.T) {
 	assert.Equal(t, 0, sizer.MetricsSize(pdata.NewMetrics()))
 }
 
+func TestProtobufMetricsSizerWithOptional(t *testing.T) {
+	sizer := NewProtobufMetricsMarshaler().(pdata.MetricsSizer)
+	marshaler := NewProtobufMetricsMarshaler()
+	md := pdata.NewMetrics()
+	metric := md.ResourceMetrics().AppendEmpty().InstrumentationLibraryMetrics().AppendEmpty().Metrics().AppendEmpty()
+	metric.SetDataType(pdata.MetricDataTypeHistogram)
+	datapoint := metric.Histogram().DataPoints().AppendEmpty()
+	datapoint.SetMin(0.1)
+	datapoint.SetMax(100)
+
+	size := sizer.MetricsSize(md)
+
+	bytes, err := marshaler.MarshalMetrics(md)
+	require.NoError(t, err)
+	assert.Equal(t, len(bytes), size)
+
+	p := NewProtobufMetricsUnmarshaler()
+	unmarshalled, err := p.UnmarshalMetrics(bytes)
+	assert.NoError(t, err)
+	assert.Equal(t, metric, unmarshalled.ResourceMetrics().At(0).InstrumentationLibraryMetrics().At(0).Metrics().At(0))
+
+}
+
 func TestProtobufLogsSizer(t *testing.T) {
 	sizer := NewProtobufLogsMarshaler().(pdata.LogsSizer)
 	marshaler := NewProtobufLogsMarshaler()

model/pdata/metrics_test.go

@@ -521,6 +521,8 @@ func TestOtlpToFromInternalHistogramMutating(t *testing.T) {
 	histogramDataPoints.At(0).SetExplicitBounds([]float64{1})
 	assert.EqualValues(t, []float64{1}, histogramDataPoints.At(0).ExplicitBounds())
 	histogramDataPoints.At(0).SetBucketCounts([]uint64{21, 32})
+	histogramDataPoints.At(0).SetMin(10.1)
+	histogramDataPoints.At(0).SetMax(27)
 	// Test that everything is updated.
 	assert.EqualValues(t, &otlpmetrics.MetricsData{
 		ResourceMetrics: []*otlpmetrics.ResourceMetrics{
@@ -549,6 +551,8 @@ func TestOtlpToFromInternalHistogramMutating(t *testing.T) {
 												TimeUnixNano:      endTime + 1,
 												BucketCounts:      []uint64{21, 32},
 												ExplicitBounds:    []float64{1},
+												Min_:              histogramDataPoints.At(0).orig.Min_,
+												Max_:              histogramDataPoints.At(0).orig.Max_,
 											},
 										},
 									},