add min/max to exponential histogram as well

open-telemetry · Mar 1, 2022 · 53371f1 · 53371f1
1 parent e4957d8
commit 53371f1
Show file tree

Hide file tree

Showing 3 changed files with 122 additions and 20 deletions.
diff --git a/model/internal/cmd/pdatagen/internal/metrics_structs.go b/model/internal/cmd/pdatagen/internal/metrics_structs.go
@@ -294,32 +294,14 @@ var histogramDataPoint = &messageValueStruct{
 			originFieldName:  "Min_",
 			originTypePrefix: "otlpmetrics.HistogramDataPoint_",
 			testValueIdx:     0, // Double
-			values: []oneOfValue{
-				&oneOfPrimitiveValue{
-					fieldName:       "Min",
-					fieldType:       "Double",
-					originFieldName: "Min",
-					returnType:      "float64",
-					defaultVal:      "float64(0.0)",
-					testVal:         "float64(17.13)",
-				},
-			},
+			values:           []oneOfValue{minField},
 		},
 		&oneOfField{
 			typeName:         "OptionalType",
 			originFieldName:  "Max_",
 			originTypePrefix: "otlpmetrics.HistogramDataPoint_",
 			testValueIdx:     0, // Double
-			values: []oneOfValue{
-				&oneOfPrimitiveValue{
-					fieldName:       "Max",
-					fieldType:       "Double",
-					originFieldName: "Max",
-					returnType:      "float64",
-					defaultVal:      "float64(0.0)",
-					testVal:         "float64(17.13)",
-				},
-			},
+			values:           []oneOfValue{maxField},
 		},
 	},
 }
@@ -370,6 +352,20 @@ var exponentialHistogramDataPoint = &messageValueStruct{
 		},
 		exemplarsField,
 		dataPointFlagsField,
+		&oneOfField{
+			typeName:         "OptionalType",
+			originFieldName:  "Min_",
+			originTypePrefix: "otlpmetrics.ExponentialHistogramDataPoint_",
+			testValueIdx:     0, // Double
+			values:           []oneOfValue{minField},
+		},
+		&oneOfField{
+			typeName:         "OptionalType",
+			originFieldName:  "Max_",
+			originTypePrefix: "otlpmetrics.ExponentialHistogramDataPoint_",
+			testValueIdx:     0, // Double
+			values:           []oneOfValue{maxField},
+		},
 	},
 }
 
@@ -556,3 +552,21 @@ var dataPointFlagsField = &primitiveTypedField{
 	defaultVal:      "MetricDataPointFlagsNone",
 	testVal:         "MetricDataPointFlagsNone",
 }
+
+var minField = &oneOfPrimitiveValue{
+	fieldName:       "Min",
+	fieldType:       "Double",
+	originFieldName: "Min",
+	returnType:      "float64",
+	defaultVal:      "float64(0.0)",
+	testVal:         "float64(17.13)",
+}
+
+var maxField = &oneOfPrimitiveValue{
+	fieldName:       "Max",
+	fieldType:       "Double",
+	originFieldName: "Max",
+	returnType:      "float64",
+	defaultVal:      "float64(0.0)",
+	testVal:         "float64(17.13)",
+}
diff --git a/model/pdata/generated_metrics.go b/model/pdata/generated_metrics.go
diff --git a/model/pdata/generated_metrics_test.go b/model/pdata/generated_metrics_test.go